refactor: change ci actions to run on push#3320
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
portuu3
approved these changes
May 7, 2025
flopez7
pushed a commit
that referenced
this pull request
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue tracking
N/A
Context behind the change
Recently changed triggers for actions, it led to actions run twice when there is a PR opened to
mainbranch and you merge a PR todevelop.The main difference between
pull_requestandpushtriggers is thatpushruns on the actual commits history from branch/ref, butpull_requestruns on "merge commit". In case we change it to always bepush- in PRs it will run on exact commit history only, removing duplicates. It should be fine because after we do actual merge we will run ondevelop/mainas onpushtrigger to see if it's all good.How has this been tested?
Release plan
Just merge
Potential risks; What to monitor; Rollback plan
No